[wp-trac] [WordPress Trac] #45719: Setting an empty post_status in wp_edit_posts_query() breaks WooCommerce list tables

WordPress Trac noreply at wordpress.org
Thu Dec 20 04:45:21 UTC 2018


#45719: Setting an empty post_status in wp_edit_posts_query() breaks WooCommerce
list tables
-------------------------------+---------------------
 Reporter:  pento              |       Owner:  (none)
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  5.0.3
Component:  Posts, Post Types  |     Version:  5.0.2
 Severity:  normal             |  Resolution:
 Keywords:                     |     Focuses:
-------------------------------+---------------------
Description changed by pento:

Old description:

> [44185] sets the `post_status` to an empty string, rather than leaving it
> unset.
>
> WooCommerce checks this query var using `isset()` rather than `empty()`
> on the Orders screen, which results in no orders showing in that list
> table.
>
> WooCommerce ref:
> https://github.com/woocommerce/woocommerce/blob/125eaaf241aabc9d8c1bd77503c3e04da6082419/includes/admin
> /list-tables/class-wc-admin-list-table-orders.php#L799

New description:

 [44185] sets the `post_status` to an empty string, rather than leaving it
 unset.

 WooCommerce checks this query var using `isset()` rather than `empty()` on
 the Orders screen, which results in no orders showing in that list table.

 [https://github.com/woocommerce/woocommerce/blob/125eaaf241aabc9d8c1bd77503c3e04da6082419/includes/admin
 /list-tables/class-wc-admin-list-table-orders.php#L799 WooCommerce
 reference].

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45719#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list