[wp-trac] [WordPress Trac] #45713: Twenty Nineteen: Improve menu semantics and keyboard navigation.

[WordPress Trac]

#45713: Twenty Nineteen: Improve menu semantics and keyboard navigation.
---------------------------+-----------------------------
 Reporter:  kjellr         |      Owner:  (none)
     Type:  defect (bug)   |     Status:  new
 Priority:  normal         |  Milestone:  Awaiting Review
Component:  Bundled Theme  |    Version:  5.0.1
 Severity:  normal         |   Keywords:  has-patch
  Focuses:                 |
---------------------------+-----------------------------
 The Twenty Nineteen menu has a couple minor semantic issues:

 - The ellipsis (...) button is currently rendered as a `span` instead of a
 `button` (originally reported in
 https://github.com/WordPress/twentynineteen/issues/723)
 - The back button in the touch navigation is also rendered as a `span`
 instead of a `button` (originally reported in
 https://github.com/WordPress/twentynineteen/issues/714 )

 The patch attached to this ticket takes care of those issues, and also
 removes an unnecessary `tabindex="0"` applied to the `main-navigation`
 element.

 ---

 This patch ports over @allancole's changes from
 https://github.com/WordPress/twentynineteen/pull/735

 ''Please note, it does not include that PRs fix for the problematic
 touchstart link behaviour in that original PR, as that's handled
 separately in #45510.''

 props:  allancole, anevins

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45713>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform