[wp-trac] [WordPress Trac] #45711: Page listing is no longer hierarchical

[WordPress Trac]

#45711: Page listing is no longer hierarchical
-------------------------------+-----------------------------
 Reporter:  david.binda        |       Owner:  (none)
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  5.0.2
Component:  Posts, Post Types  |     Version:  trunk
 Severity:  normal             |  Resolution:
 Keywords:  has-patch          |     Focuses:  administration
-------------------------------+-----------------------------
Changes (by desrosj):

 * keywords:   => has-patch


Comment:

 Thanks for reporting this, @david.binda!

 I think changing this to `empty()` is OK. There does not seem to be any
 specific reasoning for using `! isset() over `empty()`. I traced this down
 to [15491].

 @TimothyBlynJacobs I plan to open a ticket that documents all uses of
 `compact()` in core in order explore removing it (similar to how
 `extract()` was removed from core). I am hoping we can explore and
 establish a better pattern then.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45711#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform