[wp-trac] [WordPress Trac] #45453: Block Editor: Add a Message if JavaScript is disabled

[WordPress Trac]

#45453: Block Editor: Add a Message if JavaScript is disabled
------------------------------------+-----------------------
 Reporter:  mkaz                    |       Owner:  pento
     Type:  defect (bug)            |      Status:  assigned
 Priority:  normal                  |   Milestone:  5.0.3
Component:  Editor                  |     Version:  5.0
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+-----------------------
Changes (by pento):

 * keywords:  has-patch => has-patch dev-feedback
 * milestone:  5.0.2 => 5.0.3


Comment:

 Thanks for the patch, @mkaz!

 [attachment:"45453.2.diff"] makes some adjustments:

 - Use the `hide-if-js` class instead of `<noscript>`.
 - Simplify the inline CSS by hiding the `#editor` div.
 - Expand the message to recommend installing JavaScript.
 - Apply a filter to the message, so the Classic Editor plugin can filter
 it appropriately.

 I'm not wild about the inline CSS, but I'm also not aware of any existing
 class we could use the similar effect. Other screens that require JS (eg,
 the theme installer) display the `<h1>`, so don't have this squished
 margin problem.

 @azaozz: Will this filter do the job for the Classic Editor plugin to use?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45453#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform