[wp-trac] [WordPress Trac] #44416: `compact()` will throw notice for undefined variables in PHP 7.3

[WordPress Trac]

#44416: `compact()` will throw notice for undefined variables in PHP 7.3
-----------------------------+-----------------------------
 Reporter:  desrosj          |       Owner:  SergeyBiryukov
     Type:  defect (bug)     |      Status:  closed
 Priority:  normal           |   Milestone:  5.0
Component:  General          |     Version:
 Severity:  normal           |  Resolution:  fixed
 Keywords:  php73 fixed-5.0  |     Focuses:
-----------------------------+-----------------------------

Comment (by desrosj):

 In [changeset:"44186" 44186]:
 {{{
 #!CommitTicketReference repository="" revision="44186"
 Networks and Sites: Fix incorrect variable location.

 This fixes an issue introduced in [44166] where the `$groupby` variable
 was inserted too low in the `get_site_ids()` function while merging
 [43832] into `trunk`. The merged location did not account for a new
 conditional statement that existed only in `trunk`, and would have
 resulted in values assigned to `$groupby` being erased in certain
 scenarios.

 Props spacedmonkey.

 See #44416.
 Fixes #45582.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44416#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform