[wp-trac] [WordPress Trac] #45425: Add a filter to the translation file location for script localisation

WordPress Trac noreply at wordpress.org
Fri Dec 14 13:19:19 UTC 2018


#45425: Add a filter to the translation file location for script localisation
--------------------------+-------------------------
 Reporter:  johnbillion   |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  5.0.2
Component:  I18N          |     Version:  5.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  javascript
--------------------------+-------------------------

Comment (by swissspidy):

 We could probably rename `load_script_textdomain_file` to
 `load_script_translation_file` for consistency, but otherwise
 [attachment:"45425.diff"] is good to go IMO.

 @ocean90 @johnbillion @pento If anyone wants to do a final review, that'd
 be great :-)

 ----

 > Having filters on the JS side does not exclude having filters in PHP.

 Of course not, that's why this ticket and the patches exist :-)

 > Could we have a confirmation that it will be included?

 I think it's fair to say that there aren't any guarantees with open source
 projects :-)

 This ticket is currently slated for the 5.0.2 milestone and is something
 that just makes sense, so it's definitely likely to be included in that
 release.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45425#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list