[wp-trac] [WordPress Trac] #45018: Non-string needle parameters throw warning in PHP 7.3

[WordPress Trac]

#45018: Non-string needle parameters throw warning in PHP 7.3
---------------------------------------+---------------------
 Reporter:  desrosj                    |       Owner:  (none)
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  5.0
Component:  General                    |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  php73 has-patch fixed-5.0  |     Focuses:
---------------------------------------+---------------------

Comment (by desrosj):

 In [changeset:"44167" 44167]:
 {{{
 #!CommitTicketReference repository="" revision="44167"
 Nav Menus: Fix a PHP 7.3 error when switching themes.

 When switching themes, `wp_map_nav_menu_locations()` is used to ensure nav
 menus are placed in the relevant menu location. Occasionally, menus are
 registered to locations with numeric slugs, rather than strings.
 `wp_map_nav_menu_locations()` assumed it would be the latter, and ran
 `stripos()` on those numeric slugs. This behavior is deprecated in PHP
 7.3.

 As this is the last PHP 7.3 error in unit tests, this commit also removes
 PHP 7.3 from Travis' `allowed_failures` list.

 Props pento, desrosj, jorbin.

 Merges [43899] to trunk.

 See #45018.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45018#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform