[wp-trac] [WordPress Trac] #45541: Bundled Themes: Button blocks not respecting settings (was: Twenty Seventeen: Button blocks not respecting settings)

[WordPress Trac]

#45541: Bundled Themes: Button blocks not respecting settings
-----------------------------------------+----------------------------
 Reporter:  laurelfulford                |       Owner:  laurelfulford
     Type:  defect (bug)                 |      Status:  assigned
 Priority:  normal                       |   Milestone:  5.0.1
Component:  Bundled Theme                |     Version:  5.0
 Severity:  normal                       |  Resolution:
 Keywords:  needs-patch has-screenshots  |     Focuses:
-----------------------------------------+----------------------------

Old description:

> In Twenty Seventeen, the button blocks aren't respecting the different
> user styles (rounded corners, outlines). The button block styles are too
> specific.
>
> This is related (somewhat) to #45426, which is specifically about the
> colours and buttons -- some of the styles might overlap.
>
> This issue came up in the forums:
>
> https://wordpress.org/support/topic/wp-5-0-editor-button-styles-lost-
> broken/
>
> https://wordpress.org/support/topic/button-block-formatting-
> change-v-18-0/

New description:

 (Updated from just focusing on Twenty Seventeen).

 In most of the older default themes (all but Twenty Ten), the button
 blocks do not have the correct default styles. The Button block should
 default to the "Rounded" styles, and have options to display it as
 "Squared" or "Outline".

 The button default is styled after each theme's buttons; most have
 slightly rounded corners, so slight that they're hard to distinguish from
 the "Squared" version.

 This issue came up in the forums for Twenty Seventeen -- some of the issue
 described there (colours and outline button styles, not being applied) is
 already covered in #45426:

 https://wordpress.org/support/topic/wp-5-0-editor-button-styles-lost-
 broken/

 https://wordpress.org/support/topic/button-block-formatting-change-v-18-0/

--

Comment (by laurelfulford):

 Thanks @davidakennedy!

 > The default button style should be round, round enough to be noticeable.
 Most default themes aren’t that way.

 Correct! It's even called 'rounded' in the editor UI (the options are
 "Rounded", "Squared" and "Outline")

 > If we changed the button styles now, it would be only for Gutenberg
 buttons, not all buttons in the themes' designs, right?

 Yes -- and it would just be specifically for the button ''block'', so
 changes wouldn't even affect other blocks that have buttons, like the file
 block.

 > Although, I'm not thrilled about changing designs once it's out there, I
 think if we could scope it to Gutenberg-only block buttons, that would be
 okay. I'd rather have things match consistently than not for people.

 This is the way I feel, too :) I don't like the idea of it changing now,
 but at the same time, the controls don't really make any sense -- for most
 of the default themes, the buttons have the slightest border radius,
 barely distinguishable from the "Squared" option. So you have two options
 that pretty much look the same.

 Since the CSS changes will be minimal across all the themes, I'm going to
 update this ticket cover them all, and will circle back with some
 screenshots.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45541#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform