[wp-trac] [WordPress Trac] #45528: load_script_textdomain() doesn't load translations when WP installed in a subdirectory with custom content dir

WordPress Trac noreply at wordpress.org
Fri Dec 7 21:56:34 UTC 2018


#45528: load_script_textdomain() doesn't load translations when WP installed in a
subdirectory with custom content dir
-------------------------------------------------+-------------------------
 Reporter:  fierevere                            |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  5.0.1
Component:  I18N                                 |     Version:  5.0
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots needs-unit-tests     |     Focuses:
  has-patch                                      |
-------------------------------------------------+-------------------------
Changes (by herregroen):

 * keywords:  has-screenshots needs-patch needs-unit-tests => has-
     screenshots needs-unit-tests has-patch


Comment:

 This patch should work. The path resolve logic was written expecting the
 full `src` as it would be passed to the eventual script tags, which is
 what allows the easiest handling of custom directories.

 A later change during the initial patch means we now get the `src` from
 the registered object. The associated filter was run but the earlier fixes
 of the `src` were not replicated. Adding these should resolve the issue.

 Need to think a bit on how to add a proper unit test for this.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45528#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list