[wp-trac] [WordPress Trac] #42814: PHP 7.2 Warning: ...wp-includes/post-template.php on line 284

[WordPress Trac]

#42814: PHP 7.2 Warning: ...wp-includes/post-template.php on line 284
-------------------------------------------------+-------------------------
 Reporter:  internetwerk                         |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.0.1
Component:  Posts, Post Types                    |     Version:  4.5
 Severity:  normal                               |  Resolution:
 Keywords:  dev-feedback has-patch 2nd-opinion   |     Focuses:
  needs-testing php73                            |
-------------------------------------------------+-------------------------

Comment (by spacedmonkey):

 @swissspidy I have been working on a solution for both problems.
 [https://core.trac.wordpress.org/attachment/ticket/42814/42814.3.diff
 42814.3.diff] is what I came up with, as it basically removes the need to
 the globals as those varibles are generated when need them. The issue is,
 what if people have modified the globals. Maintaining the backwards compat
 is hard here. I think my patch does it...

 Will to move this chat over too #36934 people think that is a better place
 for it.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42814#comment:73>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform