[wp-trac] [WordPress Trac] #44360: Missing translators comment need to be added

WordPress Trac noreply at wordpress.org
Sun Dec 2 12:29:43 UTC 2018


#44360: Missing translators comment need to be added
----------------------------------------+-------------------------------
 Reporter:  jrf                         |       Owner:  (none)
     Type:  enhancement                 |      Status:  new
 Priority:  normal                      |   Milestone:  5.1
Component:  General                     |     Version:  trunk
 Severity:  minor                       |  Resolution:
 Keywords:  good-first-bug needs-patch  |     Focuses:  coding-standards
----------------------------------------+-------------------------------

Comment (by swissspidy):

 @tessak22 The "menus widget:" part is not needed in the translator
 comment.

 @bhaktirajdev Please note that your patch is incorrect in a few ways.

 First of all, `/* translators: %s: Welcome message  */` and `/*
 translators: %s: Thank You message for latest version updation  */` are
 wrong. The translator comment should describe the placeholder. Adding a
 comment like "Welcome message" to "Welcome to WordPress %s" is not
 really helpful :-) I think everyone gets that it's a welcome message.

 Second, the comments need to be in the PHP part of file and directly
 precede the line of the `__()` function calls. See
 [attachment:"44360.about.php.diff"] for a correct example.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44360#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list