[wp-trac] [WordPress Trac] #44865: class-wp-locale.php has a condition always false

WordPress Trac noreply at wordpress.org
Thu Aug 30 12:57:20 UTC 2018


#44865: class-wp-locale.php has a condition always false
-------------------------+---------------------
 Reporter:  naghmesara   |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  5.0
Component:  I18N         |     Version:  4.9.8
 Severity:  normal       |  Resolution:
 Keywords:               |     Focuses:  rtl
-------------------------+---------------------
Changes (by SergeyBiryukov):

 * component:  General => I18N
 * milestone:  Awaiting Review => 5.0


Comment:

 Hi @naghmesara, welcome to WordPress Trac! Thanks for the ticket.

 > strpos result always is false because does not have
 get_bloginfo('version') never ever "-src"
 Interesting. `get_bloginfo( 'version' )` does have `-src` if you run
 WordPress trunk from the [source:trunk/src/wp-
 includes/version.php?rev=43447&marks=7 src directory].

 RTL files are only available in the `build` directory, see [26107] for
 more details.

 However, with the new build process introduced in #43055,
 `WP_Locale::rtl_src_admin_notice()` and the related code is indeed
 redundant and could probably be removed, since it's no longer possible to
 run WordPress from `src` directory.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44865#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list