[wp-trac] [WordPress Trac] #44236: Maintain consistency between privacy export report and archive filenames

[WordPress Trac]

#44236: Maintain consistency between privacy export report and archive filenames
-------------------------------------------------+-------------------------
 Reporter:  iandunn                              |       Owner:  GripsArt
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  low                                  |   Milestone:  4.9.9
Component:  Privacy                              |     Version:  4.9.6
 Severity:  minor                                |  Resolution:
 Keywords:  good-first-bug needs-testing has-    |     Focuses:
  patch needs-refresh needs-unit-tests           |
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  good-first-bug needs-testing has-patch => good-first-bug
     needs-testing has-patch needs-refresh needs-unit-tests


Comment:

 @GripsArt good progress on this. Thanks for working on it. I have a few
 suggestions.

 The value being filtered is `$file_basename`, so the result of the filter
 should be saved to that variable. The `$file_basename` variable is used
 further down in the function to name the ZIP file, but with the filter
 where it is in [attachment:"44263.3.patch"], the ZIP file name would not
 match if the value is filtered. It's also best to not perform other
 operations on the same line that a filter is applied to be clearer.

 Nitpicky things:
 - [https://make.wordpress.org/core/handbook/best-practices/inline-
 documentation-standards/php/#1-functions-class-methods Inline
 documentation descriptions should always end with a period].
 - There is an extra space between `string` and `$file_basename` in the
 `@param` tag.
 - `the` in `the personal data export` should be capitalized.

 I also would like these changes should be accompanied by unit tests, but
 they would need to be added to the test class being worked on in #44233.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44236#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform