[wp-trac] [WordPress Trac] #44600: Update WPCS to 1.0.0, and enforce coding standards

WordPress Trac noreply at wordpress.org
Thu Aug 16 07:57:03 UTC 2018


#44600: Update WPCS to 1.0.0, and enforce coding standards
------------------------------+-------------------------------
 Reporter:  pento             |       Owner:  pento
     Type:  task (blessed)    |      Status:  assigned
 Priority:  normal            |   Milestone:  5.0
Component:  Build/Test Tools  |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:                    |     Focuses:  coding-standards
------------------------------+-------------------------------

Comment (by pento):

 Replying to [comment:9 jrf]:
 > That's what the `composer.lock` file is for.... or am I missing
 something ?

 I'm a dummy, I forgot why we had to do that in Gutenberg: we were working
 with versions of `npm` that didn't support `package-lock.json`, so had to
 lock the versions ourselves. We can use `composer.lock` here.

 > Now 1.0.0 has been released, it is my intention to release more
 regularly, especially when there are notable changes. What with WPCS using
 semantic versioning, releasing new versions should be easier now as the
 versioning communicates the impact of the release.

 Cool, let's try and get a release out with the customisations we currently
 have in `phpcs.xml.dist`. I don't mind a process where we make tweaks in
 Core's `phpcs.xml.dist`, then remove them when they're moved to WPCS,
 instead.

 > Would you mind opening an issue in WPCS for this ? This is a significant
 change, so I'd like to see some responses from the community before making
 it, though I personally fully support this change.

 Is [https://github.com/WordPress-Coding-Standards/WordPress-Coding-
 Standards/issues/1323 WPCS#1323] sufficient?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44600#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list