[wp-trac] [WordPress Trac] #44550: The confirmaction page should also be in the user language

[WordPress Trac]

#44550: The confirmaction page should also be in the user language
-------------------------------------------------+-------------------------
 Reporter:  birgire                              |       Owner:  desrosj
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.9.9
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots needs-testing has-   |     Focuses:
  patch                                          |  administration
-------------------------------------------------+-------------------------

Comment (by birgire):

 Thank you @desrosj

 Modifying the confirmation url seems to be relevant approach for this one.

 Whether to include the locale info in the confirmation url:

 1. Unregistered users (uses site's locale):                      No
 2. Registered users, with locale set:                                 Yes
 3. Registered users, without locale set (fallback as site's locale): No

 I think this is contained in the tests in [attachment:"44550.3.diff"],
 that run successfully through phpunit on my install.

 The confirmaction page in cases 1) and 3) follows any changes made on the
 site's locale.

 An edge cases for 2): A registered user changes to locale Y, after
 receiving an email containing the confirmation url with a previous locale
 X.

 I've not checked, but wonder if the user is logged in, if that should
 override the {{{wp_lang}}} value in the confirmation url. Maybe it is so?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44550#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform