[wp-trac] [WordPress Trac] #43749: Update zxcvbn to 4.4.2

WordPress Trac noreply at wordpress.org
Tue Aug 14 22:27:17 UTC 2018


#43749: Update zxcvbn to 4.4.2
-------------------------------------+-----------------------------
 Reporter:  desrosj                  |       Owner:  (none)
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  Future Release
Component:  External Libraries       |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  javascript
-------------------------------------+-----------------------------

Comment (by omarreiss):

 43749.5.diff should fix all the mentioned issues.

 > It seems that the file is not being fully PGified.

 Only applied the transformation on the passwords list. Made it so that all
 the frequency lists are now transformed.

 > Also, if you edit a user and type a password into the field, it says
 "Password strength unknown".

 The `rot` function was prepended without a semicolon at the end. That
 caused it to not be defined. Fixed now.

 > Also, how do you feel about adding a new 822KB file to core?

 I agree. Made it like it was.

 @desrosj could you maybe test?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43749#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list