[wp-trac] [WordPress Trac] #44233: Add missing unit tests for exporting personal data by username or email address

WordPress Trac noreply at wordpress.org
Tue Aug 14 17:51:44 UTC 2018


#44233: Add missing unit tests for exporting personal data by username or email
address
-------------------------+------------------------
 Reporter:  desrosj      |       Owner:  desrosj
     Type:  enhancement  |      Status:  reviewing
 Priority:  low          |   Milestone:  4.9.9
Component:  Privacy      |     Version:  4.9.6
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+------------------------

Comment (by birgire):

 Awesome @desrosj, thanks for digging into the 5.2 case. Good to know about
 the general exception support.

 > The test_function_detects_cannot_write_html() and
 test_function_detects_cannot_create_index() functions are still failing
 locally for me, though.

 It seems that the mode of:

 {{{
 mkdir( $pathname, $mode )

 }}}

 isn't supported on Windows.

 https://secure.php.net/manual/en/function.mkdir.php

 Could that be the reason?

 Maybe skip those tests for Windows that depend on setting the mode?

 In future it would be nice to be able to make these filesystem checks
 virtually (vfs).

 Then there is {{{WP_Filesystem_MockFS}}} for {{{WP_Filesystem}}}.

 It runs successfully on my Linux node.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44233#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list