[wp-trac] [WordPress Trac] #40364: Improve site creation in multisite

WordPress Trac noreply at wordpress.org
Wed Aug 1 12:41:52 UTC 2018


#40364: Improve site creation in multisite
-------------------------------------------------+-------------------------
 Reporter:  jeremyfelt                           |       Owner:  flixos90
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.0
Component:  Networks and Sites                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  ms-roadmap has-patch has-unit-tests  |     Focuses:  multisite
  needs-dev-note                                 |
-------------------------------------------------+-------------------------

Comment (by flixos90):

 [attachment:"40364.14.diff"] implements the final change that was agreed
 on in yesterday's office hours meeting: When `0000-00-00 00:00:00` is
 stored as one of the site date values for whatever reason (the new
 functions catch that, but for whatever reason old code might not have), we
 wanna ensure this validation doesn't fail. Therefore
 `wp_validate_site_data()` now allows that "empty" date to be passed. Note
 that it is stripped out before though, if it is actually passed to
 `wp_insert_site()` or `wp_update_site()`, so this is only an extra BC
 measure to account for old data, as throwing an error then would be
 unexpected. Two test datasets to verify this behavior have been added.

 In yesterday's discussion we determined this is ready. I'll commit
 shortly.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/40364#comment:61>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list