[wp-trac] [WordPress Trac] #41074: Create new Dashicons (4.9)

WordPress Trac noreply at wordpress.org
Mon Apr 30 06:43:56 UTC 2018


#41074: Create new Dashicons (4.9)
---------------------------+------------------------
 Reporter:  EmpireOfLight  |       Owner:  netweb
     Type:  enhancement    |      Status:  reviewing
 Priority:  normal         |   Milestone:  5.0
Component:  Editor         |     Version:  4.9
 Severity:  normal         |  Resolution:
 Keywords:  needs-refresh  |     Focuses:  ui
---------------------------+------------------------

Comment (by Joen):

 > @Joen are there any Gutenberg-related icons that would be good to land
 before 5.0 or are you all ok waiting for those icons to land alongside
 Gutenberg in 5.0?

 We don't _need_ any icons to land before 5.0, no. In fact, for now and
 because we've needed to be able to create icons for Gutenberg _fast_,
 every new icon created for Gutenberg are in a separate directory:
 https://github.com/WordPress/dashicons/tree/master/sources/svg/gutenberg

 Icons in that directory are not added into the icon font, they are added
 only to the SVG sprite. But anyone should feel free to comment on their
 design.

 I think the most important thing to review, though, is the new build
 process. Recent work was done in
 https://github.com/WordPress/dashicons/pull/246. The build process means
 that creating new icons is not an arduous process, which is important so
 as to keep the project alive. It comes with only two changes per how it's
 been done in the past:

 1.  we can't edit `url("...")` to be `url( "..." )` without hacking core
 files.
 2. we can't customize the order of the icons, nor add "grouping" headers.
 Icons are output alphabetically

 1 I don't care about, it seems a trivial price to pay for taking the
 vinegar and human error aspect out of adding icons. 2 I personally think
 is a benefit. But nonetheless these are aspects that should be considered
 before switching to the process-built icon font, which I believe still
 hasn't happened?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/41074#comment:55>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list