[wp-trac] [WordPress Trac] #38545: Add span element to get_the_archive_title()

[WordPress Trac]

#38545: Add span element to get_the_archive_title()
-------------------------+---------------------
 Reporter:  Kaira        |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  4.9.6
Component:  Taxonomy     |     Version:  4.6.1
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+---------------------

Comment (by desrosj):

 Thanks, @audrasjb.

 Reviewed and have a few notes:

 - The parameter descriptions for `the_archive_title()` should all be
 aligned.
 - `the_archive_title()` should have a `@since` tag stating when that the
 new parameter was added.
 - The version on the new `@since` tag on `get_the_archive_title()` is
 wrong.
 - If the placeholders are removed from the translatable strings, the `/*
 translators: */` comments are no longer needed.
 - The `$span_class` should also be passed to the `get_the_archive_title`
 filter (remember to add a `@since` tag).

 After taking a deeper look at this one, I agree with @Clorith about this
 not going into a minor. In the currently proposed approach, a `<span>` is
 ''always'' added even if the class parameter is empty. This would
 definitely have the potential for causing issues in themes.

 If the `<span>` was 'output ''only'' if there was a class provided to the
 function, then this could be considered for a minor release. But, I am not
 sure that would be best.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/38545#comment:44>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform