[wp-trac] [WordPress Trac] #41191: Create browse happy type notice for PHP versions

[WordPress Trac]

#41191: Create browse happy type notice for PHP versions
-------------------------------------------------+-------------------------
 Reporter:  joostdevalk                          |       Owner:  flixos90
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  4.9.6
Component:  General                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch ui-feedback needs-testing  |     Focuses:
                                                 |  accessibility
-------------------------------------------------+-------------------------

Comment (by flixos90):

 After recent discussions and the additional feedback and patch from
 @johnjamesjacoby, [attachment:41191.12.diff] is an iteration on
 [attachment:41191.10.diff] which takes a couple of suggestions (partly
 from [attachment:41191.11.2.diff]) into account. Changes made:

 * Fix incorrect statement "WordPress has detected that your site is
 running on an insecure version of PHP, which means that a faster website
 is just a quick update away." by removing the second part of that
 sentence. That furthermore makes it a more clear statement, and the aspect
 of speed is mentioned in the second paragraph anyway.
 * Remove the whole last section that essentially just revolves around the
 user needing to click the button. It helps further shortening the copy, as
 requested by the design team, and was redundant.
 * Left-align button and make it regular-size, as requested by the design
 team and in [attachment:41191.11.2.diff]. @johnjamesjacoby We cannot
 shorten the button text itself, as "Learn more" makes it too unclear this
 link helps with updating PHP.
 * If the PHP version is not insecure, but only out-of-date, show the icon
 with yellow color, as requested by the design team. This change is to be
 future-proof, but note that at this point, it will never be rendered this
 way because we show the notice only on 5.2 which ''is'' insecure.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/41191#comment:108>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform