[wp-trac] [WordPress Trac] #41191: Create browse happy type notice for PHP versions

[WordPress Trac]

#41191: Create browse happy type notice for PHP versions
-------------------------------------------------+-------------------------
 Reporter:  joostdevalk                          |       Owner:  flixos90
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  4.9.6
Component:  General                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch ui-feedback needs-testing  |     Focuses:
                                                 |  accessibility
-------------------------------------------------+-------------------------

Comment (by flixos90):

 @johnjamesjacoby
 > Given that requirement, none of the other buttons or links in core make
 any more sense than what I’m proposing. “Learn more” actually better
 matches the deeply ingrained general WordPress voice.

 We can have the best out of both worlds by doing the following: `__(
 'Learn more<span class="screen-reader-text"> about updating PHP</span>' )`

 > Hacking `do_meta_boxes()` to hardcode a `dashboard_php_nag` check is
 proof this is the wrong approach.

 While it is terrible we need to hack to accomplish that, this indicates a
 lack of flexibility in the Meta Boxes API. The Browsehappy notice has been
 doing that as well. These two meta boxes are special, since they only
 appear conditionally to inform the user about significant issues with
 their setup - so I think it’s okay for them to have special handling.

 I‘ll have more time to look at your suggestions and give feedback later.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/41191#comment:107>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform