[wp-trac] [WordPress Trac] #43316: REST API: Support autosaves

WordPress Trac noreply at wordpress.org
Mon Apr 23 12:29:42 UTC 2018


#43316: REST API: Support autosaves
-------------------------------------------------+-------------------------
 Reporter:  kraftbj                              |       Owner:  rmccue
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.0
Component:  REST API                             |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-unit-  |     Focuses:  rest-api
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by danielbachhuber):

 I did a read of the GitHub pull request and want to cross-post some
 nitpicks about 43316.14.diff:

 * Why do we need to instantiate a `$this->revision_controller` instance if
 we're subclassing the revisions controller in the first place?
 * Re: `create_item_permissions_check()`, I'd be concerned about a point in
 the future where
 `$this->parent_controller->update_item_permissions_check()` changed and
 caused an unexpected change in behavior in this controller. If we want to
 create an explicit internal API for this, we should do so; otherwise, we
 should copy the contents into this method.
 * Re: `create_item()`, we should change the `id` argument into `post` or
 something else. `id` is always a read-only value generated by the database
 elsewhere in the REST API.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43316#comment:80>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list