[wp-trac] [WordPress Trac] #43755: CS: Fix violations for wp-includes/canonical.php

WordPress Trac noreply at wordpress.org
Fri Apr 13 11:41:57 UTC 2018


#43755: CS: Fix violations for wp-includes/canonical.php
--------------------------+-------------------------------
 Reporter:  jipmoors      |       Owner:  netweb
     Type:  defect (bug)  |      Status:  reviewing
 Priority:  normal        |   Milestone:  5.0
Component:  Canonical     |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  coding-standards
--------------------------+-------------------------------

Comment (by jipmoors):

 Have made some additional changes to make sure `wp_parse_url` is used on
 all occasions.

 Also to be able to ignore the `prepare` statement sniff, have made sure
 all parts of the query have been prepared.
 I can imagine this could be a separate patch or at least be a separate
 commit, but it was in line of fixing the code sniff.

 Have ran all unit tests and did not encounter any problems.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43755#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list