[wp-trac] [WordPress Trac] #43728: Implements site_enable_theme and site_disable_theme functions in WP_Theme class

WordPress Trac noreply at wordpress.org
Tue Apr 10 09:35:02 UTC 2018


#43728: Implements site_enable_theme and site_disable_theme functions in WP_Theme
class
----------------------------------------+------------------------------
 Reporter:  Mista-Flo                   |       Owner:
     Type:  enhancement                 |      Status:  new
 Priority:  normal                      |   Milestone:  Awaiting Review
Component:  Themes                      |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:  multisite
----------------------------------------+------------------------------
Changes (by flixos90):

 * keywords:  has-patch => has-patch needs-unit-tests


Comment:

 @Mista-Flo

 [attachment:43728.1.patch] looks good, just a few improvements:

 * The paramters should be switched: `$stylesheets` should be first, the
 optional `$site_id` parameter second, as it falls back to the current site
 ID if not given.
 * The parameter doc-block entries should be properly aligned with spaces.
 * At the beginning of the methods, `$site_id` must be cast to an integer,
 to make sure the strict comparisons afterwards work correctly.

 We'll also need a few tests to verify the correct behavior.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43728#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list