[wp-trac] [WordPress Trac] #40138: Bundled themes: the tag cloud widget should output a list

WordPress Trac noreply at wordpress.org
Wed Sep 27 09:53:24 UTC 2017


#40138: Bundled themes: the tag cloud widget should output a list
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:
     Type:  enhancement                          |  sami.keijonen
 Priority:  normal                               |      Status:  assigned
Component:  Bundled Theme                        |   Milestone:  4.9
 Severity:  normal                               |     Version:
 Keywords:  tag-cloud has-patch 2nd-opinion      |  Resolution:
  needs-testing                                  |     Focuses:  ui,
                                                 |  accessibility
-------------------------------------------------+-------------------------

Comment (by sami.keijonen):

 I tested with 40138.diff and here are my notes. I'll note the version
 number also but I'm not sure how you handle it.

 == Twenty Sixteen ==

 - There is left margin on the UL-list which changes the design a little
 bit.
 - There is also bottom margin but that doesn't change design.
 - Update version to @since Twenty Sixteen 1.4.


 == Twenty Fifteen ==

 - Looks good to me
 - Update version to @since Twenty Fifteen 1.9.

 == Twenty Fourteen ==

 - Looks good to me
 - Update version to @since Twenty Fourteen 2.1.

 == Twenty Thirteen ==

 - `.widget li` gives 5px padding top and bottom.  I'd probably give some
 spacing but on the top and right as in previous. Something like:
 {{{
 .tagcloud ul li {
 padding: 4px 4px 0 0;
 }
 }}}

 - Update version to @since Twenty Thirteen 2.3.

 == Twenty Twelve ==

 - `.widget-area .widget li` will give extra line-height. Font-size doesn't
 have an effect.
 - Update version to @since Twenty Twelve 2.4.

 == Twenty Eleven ==

 - Looks good to me.
 - Update version to @since Twenty Eleven 2.7.

 == Twenty Ten ==

 - Looks good to me.
 - Update version to @since Twenty Ten 2.4.

 ----
 @xkon Do you happen to have time to fix these? Wait for a while anyways
 before David have reviewed this also.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40138#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list