[wp-trac] [WordPress Trac] #42004: Standardise api.wordpress.org requests

[WordPress Trac]

#42004: Standardise api.wordpress.org requests
-----------------------------+---------------------
 Reporter:  dd32             |       Owner:  dd32
     Type:  defect (bug)     |      Status:  closed
 Priority:  normal           |   Milestone:  4.9
Component:  Upgrade/Install  |     Version:
 Severity:  normal           |  Resolution:  fixed
 Keywords:                   |     Focuses:
-----------------------------+---------------------

Comment (by dd32):

 Just to note:

 The unreachable & retry-over-HTTP code from the core/plugins/themes update
 checks were not copied over to Browse Happy, Importers, Events, or Credits
 API calls. In these areas it's not as critical if the requests fail
 gracefully (Importers has a hard-coded list as a backup). While Events
 could benefit from it, it's unlikely to be a significant group of users
 for whom SSL requests are failing currently (where WordPress thinks it'll
 work, but doesn't).

 The `User-Agent` standardised on is what is used for the Core version
 check, everything else was similar but slightly different, trailing
 slashing differences and possibly scheme differences based on different
 filters applying to the URL.
 I only changed the `User-Agent` sent to api.wordpress.org, as we
 specifically override it in this case. The `User-Agent` used for general
 HTTP requests is not a trailing-slashed URL, while we send a trailing-
 slashed URL to api.wordpress.org.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42004#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform