[wp-trac] [WordPress Trac] #41983: Lead by example: pass unquoted placeholders to $wpdb->prepare()

WordPress Trac noreply at wordpress.org
Tue Sep 26 20:19:19 UTC 2017


#41983: Lead by example: pass unquoted placeholders to $wpdb->prepare()
--------------------------+------------------------------
 Reporter:  jrf           |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Database      |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------------------

Comment (by jrf):

 @johnjamesjacoby Thanks for adding the patch and good call on the doc fix.
 I think the descriptive documentation could be improved a little as well
 to state that `%` wildcards to be used with `LIKE` should not be passed to
 the function as that is unclear unless you study the code sample.

 The `wpdb->prepare()` documentation should probably also be more explicit
 about how `%` wildcards in `LIKE` statements should be passed. /cc
 @DrewAPicture


 Also: did you mean to commit this extra file to the patch: `wp-content/db-
 plugins/ludicrousdb src/wp-content/db-plugins/ludicrousdb` ?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41983#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list