[wp-trac] [WordPress Trac] #12423: Include default code editor

[WordPress Trac]

#12423: Include default code editor
---------------------------------------------+----------------------------
 Reporter:  scribu                           |       Owner:  westonruter
     Type:  feature request                  |      Status:  closed
 Priority:  normal                           |   Milestone:  4.9
Component:  Editor                           |     Version:  3.0
 Severity:  normal                           |  Resolution:  fixed
 Keywords:  has-patch commit needs-dev-note  |     Focuses:  accessibility
---------------------------------------------+----------------------------

Comment (by Clorith):

 A must have is fatal error detection, we really shouldn't have included
 (with heavy focusing on) the new editor without this (apologies for the
 late input).

 Scenario:
 User googles how to do something, is presented with a result that says
 "paste this code into `functions.php`".
 The user, following the steps, does this, not knowing that this is a guide
 specifically crafted for ''Awesome Plugin''.

 The pasted code includes a call to `awesome_plguin_feature();` which they
 do not have on their site.

 They've just fataled their site, including wp-admin, and are unable to
 remedy the error they made. The user is unfamiliar with code editing and
 as such are now lost as they can't fix their site.

 This scenario can easily translate into a function name with a typo as
 well, or many other scenarios.

 ---

 The approach we should take is to hit the site with a HTTP Head check, and
 at a minimum look for 5xx errors that are indicative of a server level
 error after the edit, and revert any changes made with a notice to the
 user that their changes were not saved.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/12423#comment:151>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform