[wp-trac] [WordPress Trac] #37937: Support boolean strings for the 'public', 'archived', 'mature', 'spam' and 'deleted' attributes in WP_Site_Query

WordPress Trac noreply at wordpress.org
Mon Sep 18 17:53:42 UTC 2017


#37937: Support boolean strings for the 'public', 'archived', 'mature', 'spam' and
'deleted' attributes in WP_Site_Query
--------------------------------------+------------------------------
 Reporter:  birgire                   |       Owner:
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Networks and Sites        |     Version:  4.6
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  multisite
--------------------------------------+------------------------------

Comment (by desrosj):

 Following up on the discussion in today's ticket scrub. @birgire will
 combine the tests and fix patches into one. Also, some feedback on the
 patch.

 - The empty line between the inline documentation and the function in the
 tests needs to be removed.
 - The tests only test the `public` parameter. The others should be tested
 as well.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37937#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list