[wp-trac] [WordPress Trac] #41417: Error when opening up Thickbox lightbox on plugins page

[WordPress Trac]

#41417: Error when opening up Thickbox lightbox on plugins page
----------------------------------------------+----------------------------
 Reporter:  moeloubani1                       |       Owner:  afercia
     Type:  defect (bug)                      |      Status:  assigned
 Priority:  normal                            |   Milestone:  4.9
Component:  Administration                    |     Version:  4.5
 Severity:  normal                            |  Resolution:
 Keywords:  has-screenshots has-patch commit  |     Focuses:  ui,
                                              |  javascript
----------------------------------------------+----------------------------
Changes (by afercia):

 * keywords:  has-screenshots has-patch => has-screenshots has-patch commit


Comment:

 [attachment:41417.2.diff] handles a potential edge case in the plugins
 page when another instance of thickbox might want to load an iframe with
 content from an external domain. To test the patch, add this content in a
 few admin pages and check the modal opens without errors:


 {{{
 <?php add_thickbox(); ?>
 <a href="#TB_inline?width=600&height=550&inlineId=my-hidden-content"
 class="thickbox">View my inline content!</a>
 <div id="my-hidden-content" style="display: none;"><p>Hello!</p></div><br>
 <a href="http://example.org?TB_iframe=true&width=600&height=550"
 class="thickbox">View my iframe content!</a>

 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41417#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform