[wp-trac] [WordPress Trac] #39693: Fix missing assignment of widgets on theme switch

[WordPress Trac]

#39693: Fix missing assignment of widgets on theme switch
--------------------------------------+--------------------------
 Reporter:  melchoyce                 |       Owner:  westonruter
     Type:  enhancement               |      Status:  reviewing
 Priority:  normal                    |   Milestone:  4.9
Component:  Widgets                   |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+--------------------------

Comment (by alexvorn2):

 Replying to [comment:88 westonruter]:
 > In [attachment:39693.6.diff]:
 > * I was working on [https://github.com/xwp/wp-theme-nav-menu-widget-
 sidebar-permutations/blob/master/tests/widget-sidebars/scenarios.json
 scenarios] for testing the various sidebar [https://github.com/xwp/wp-
 theme-nav-menu-widget-sidebar-permutations theme permutations], and I
 found a [https://github.com/xwp/wp-theme-nav-menu-widget-sidebar-
 permutations/blob/c1f2074d060167f43e8eaa880a8e32859a00764a/tests/widget-
 sidebars/scenarios.json#L36-L45 scenario] where from a theme with 3
 populated sidebars to a theme with 2 sidebars and then switching back to
 the theme with 3 sidebars results in the one sidebar that was not
 initially mapped being ''empty'' after having switched back. This seems
 bad to me. I think this is part of the orphaned sidebar question.

 Some widgets show in a Orphaned Sidebars because the number of sidebars in
 the current theme is fewer than in the old theme, so the solution I think
 is that we can move the widgets to the Inactive Widgets sidebar as for
 now. Seeing multiple Orphaned Sidebars seems not OK for me.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39693#comment:89>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform