[wp-trac] [WordPress Trac] #41610: Widgets: Change "close" to "done?"

[WordPress Trac]

#41610: Widgets: Change "close" to "done?"
-------------------------+------------------
 Reporter:  melchoyce    |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  4.9
Component:  Widgets      |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+------------------
Changes (by westonruter):

 * keywords:   => has-patch
 * milestone:  Awaiting Review => 4.9


Comment:

 @timmydcrawford what if someone clicks “Done” without having saved the
 widget? Maybe someone would click “Done” without having clicked “Save”
 first? Maybe it should only say “Done” only in the Customizer?

 I've amended the PR to prototype the addition of an AYS dialog on the
 widgets admin screen if you try to leave without having saved all the
 widgets you modified. Additionally, a widget's Save button is disabled
 when the widget is first expanded, but then once a field is modified then
 the button is enabled, until hitting Save causes the dirty flag to be
 cleared and the button re-disables: [https://github.com/xwp/wordpress-
 develop/pull/250/commits/715884d 715884d].

 This would fix something that bugged me when testing media widgets where
 I'd select an image for the Image widget, but then I'd forget to hit Save
 on the widgets admin screen so the image never got saved to the DB.

 This would essentially also fix #23120, and it seems like something that
 would be necessary if we add “Done” here. Maybe the “Done” link would only
 be shown when the widget is saved on the widgets admin screen? In the
 Customizer the “Done” link could always be displayed because whenever you
 make a change it is written into the changeset. I've implemented this
 change in [https://github.com/xwp/wordpress-
 develop/pull/250/commits/9a4a607 9a4a607].

 It feels much better now interacting with widgets on the widgets admin
 screen with these changes.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41610#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform