[wp-trac] [WordPress Trac] #42357: NewMenuControl class has been removed from trunk

[WordPress Trac]

#42357: NewMenuControl class has been removed from trunk
--------------------------+-----------------------
 Reporter:  herregroen    |       Owner:  bpayton
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.9
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+-----------------------
Changes (by westonruter):

 * keywords:   => needs-patch
 * owner:   => bpayton
 * status:  new => assigned
 * milestone:  Awaiting Review => 4.9


Old description:

> In the recent changes to `src/wp-admin/js/customize-nav-menus.js` the
> `NewMenuControl` seems to have been removed.
>
> This seems to be the revision in which it was removed:
> https://core.trac.wordpress.org/browser/trunk/src/wp-admin/js/customize-
> nav-menus.js?rev=41768.
>
> Considering the revision message mentions nothing about removing said
> class and there are no deprecation notices in the previous revision (
> https://core.trac.wordpress.org/browser/trunk/src/wp-admin/js/customize-
> nav-menus.js?rev=41726 ) this is probably a mistake I would guess?
>
> I felt it probably best to open a ticket since it seems weird for a class
> to be removed without any deprecation warnings or clear notice.

New description:

 In the recent changes to `src/wp-admin/js/customize-nav-menus.js` the
 `NewMenuControl` seems to have been removed.

 This seems to be the revision in which it was removed:
 https://core.trac.wordpress.org/browser/trunk/src/wp-admin/js/customize-
 nav-menus.js?rev=41768.

 Considering the revision message mentions nothing about removing said
 class and there are no deprecation notices in the previous revision (
 https://core.trac.wordpress.org/browser/trunk/src/wp-admin/js/customize-
 nav-menus.js?rev=41726 ) this is probably a mistake I would guess?

 I felt it probably best to open a ticket since it seems weird for a class
 to be removed without any deprecation warnings or clear notice.

 Introduced in #40104.

--

Comment:

 @bpayton We need to find a way to not remove the class to add back-compat.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42357#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform