[wp-trac] [WordPress Trac] #41526: Remove usage of each() from Text_Diff_Engine_native

[WordPress Trac]

#41526: Remove usage of each() from Text_Diff_Engine_native
------------------------------------------+--------------------------
 Reporter:  johnbillion                   |       Owner:  johnbillion
     Type:  task (blessed)                |      Status:  reopened
 Priority:  normal                        |   Milestone:  4.9.1
Component:  External Libraries            |     Version:
 Severity:  normal                        |  Resolution:
 Keywords:  needs-unit-tests needs-patch  |     Focuses:
------------------------------------------+--------------------------

Comment (by SergeyBiryukov):

 For reference, here are the upstream commits that [41633] was based upon:
 https://github.com/horde/Text_Diff/commit/65f92a945f3745be2953d2bcc24735e860cf70a7
 https://github.com/horde/Text_Diff/commit/bd9b0e05ad38ad32d55cf7188617ec3b0d906088

 > The `Text_Diff` library is a complex, third-party script with no test
 coverage, so changes here need to be made carefully. Unit tests probably
 could be introduced to demonstrate no regressions when `each()` is
 replaced.

 Looks like it does have tests:
 https://github.com/horde/Text_Diff/tree/master/test/Horde/Text/Diff. If
 someone can write a test using the data from comment:5, and/or figure out
 why exactly the `foreach()` version fails, might be worth reporting this
 upstream.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41526#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform