[wp-trac] [WordPress Trac] #42184: Customizer theme install getting stuck on downloading

[WordPress Trac]

#42184: Customizer theme install getting stuck on downloading
--------------------------+-------------------------------
 Reporter:  helen         |       Owner:  celloexpressions
     Type:  defect (bug)  |      Status:  reviewing
 Priority:  normal        |   Milestone:  4.9
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+-------------------------------
Changes (by celloexpressions):

 * keywords:  needs-patch => has-patch


Comment:

 Replying to [comment:15 westonruter]:
 > After dismissing the file credentials modal, I'm still seeing the same
 thing as [attachment:after-credential-modal-cancel.png], where both
 buttons say “Install”.
 Known issue noted in [comment:11]. The problem is that `updates.js`
 doesn't address multiple buttons with the same action; I don't see a
 minimally-hacky way to fix this without more broadly refactoring the
 integration. However, this only happens when a model is open, so it will
 be rarely encountered.

 [attachment:42184.2.diff] fixes the failed theme download error handling
 following the new notifications API, which is something that users will
 run into much more frequently (for example, an intermittent internet
 connection or downtime on .org). The buttons still stop working for that,
 but they do show a notification failed error. It seems like it would be
 worth more broadly evaluating the error handling here, likely in a future
 (potentially minor) release so that there's time to consider all error
 cases to handle and refactor things at a higher level.

 Summary of issues fixed in [attachment:42184.2.diff]:
 - Theme download error handling restored following the use of a
 notifications API for the downloading overlay.
 - Introduce preliminary customize-specific logic for the modal credential
 cancel handler.
 - Ensure that scripts for the credentials modal are correctly enqueued.

 Are there any other issues here that seem fixable for 4.9? Would be good
 to get the progress into beta 4, at least, for broader testing.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42184#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform