[wp-trac] [WordPress Trac] #41872: Code Editor: Minor accessibility improvements to the CodeMirror editing areas

WordPress Trac noreply at wordpress.org
Fri Oct 20 16:38:37 UTC 2017


#41872: Code Editor: Minor accessibility improvements to the CodeMirror editing
areas
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:  afercia
     Type:  defect (bug)             |      Status:  closed
 Priority:  high                     |   Milestone:  4.9
Component:  Customize                |     Version:  trunk
 Severity:  normal                   |  Resolution:  fixed
 Keywords:  has-patch has-           |     Focuses:  ui, accessibility,
  screenshots commit                 |  administration
-------------------------------------+-------------------------------------

Comment (by westonruter):

 In [changeset:"41957"]:
 {{{
 #!CommitTicketReference repository="" revision="41957"
 Code Editor: Improve ability to create Customizer `CodeEditorControl`
 instances in JS, lessening PHP dependencies.

 Allow `CodeEditorControl` to be instantiated with a `editor_settings`
 param which is merged with `wp.codeEditor.defaultSettings`.

 Also:

 * Turn redundant "CSS Code" control label into screen reader text for
 Additional CSS.
 * Remove `code-editor` as script dependency for `custom-html-widgets`
 since enqueueing is determined by `wp_enqueue_code_editor()`.
 * Remove useless exporting of `code_type` param to JS in
 `WP_Customize_Code_Editor_Control`.
 * Add `disabled` class to Custom HTML widget's Save button when linting
 errors are present.
 * Remove redundant `span` inside CodeEditorControl's `label`.

 See #41897, #12423, #41872.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41872#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list