[wp-trac] [WordPress Trac] #38583: Support for objects in schema validation and sanitization

[WordPress Trac]

#38583: Support for objects in schema validation and sanitization
----------------------------------------+-----------------------
 Reporter:  rachelbaker                 |       Owner:  rmccue
     Type:  enhancement                 |      Status:  reopened
 Priority:  high                        |   Milestone:  4.9
Component:  REST API                    |     Version:  4.7
 Severity:  major                       |  Resolution:
 Keywords:  has-unit-tests needs-patch  |     Focuses:
----------------------------------------+-----------------------
Changes (by westonruter):

 * keywords:  has-patch has-unit-tests dev-feedback => has-unit-tests needs-
     patch
 * severity:  normal => major


Comment:

 I agree we need to retain this behavior:

 > ie, the default should be to ALLOW additional properties, not exclude
 them.

 I've had a [https://github.com/WP-API/wp-api-customize-
 endpoints/pull/10#pullrequestreview-43035491 conversation previously]
 about how adding `additionalProperties: true` to a schema is good just to
 be explicit, even though it is the default. If the behavior changes where
 this is no longer the default, things will break.

 Increasing severity as it conflicts with JSON Schema spec and breaks back-
 compat.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38583#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform