[wp-trac] [WordPress Trac] #42205: FTP credentials dialog gets hidden behind things

[WordPress Trac]

#42205: FTP credentials dialog gets hidden behind things
--------------------------------------+------------------
 Reporter:  helen                     |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  low                       |   Milestone:  4.9
Component:  Customize                 |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:  ui
--------------------------------------+------------------
Changes (by afercia):

 * component:  Upgrade/Install => Customize
 * milestone:  Awaiting Review => 4.9


Comment:

 Hm, the customizer uses `visibility: hidden` on the body when there are
 full overlays, to completely hide all elements except the customizer. This
 has the advantage to make the customizer the only perceivable content in
 the page, and its focusable elements the only ones in the page (no need to
 constrain tabbing within the full overlays, etc.)

 However, the FTP credentials modal is inside `wp-body-content` so it
 inherits `visibility: hidden`. A proper fix would be setting `visibility:
 visible` on the modal using just CSS.

 To evaluate: why the FTP credentials modal is inside `wp-body-content`?
 Ideally, all modals should be placed in the source before the `</body>`.
 To evaluate: maybe the customizer should set `visibility: hidden` on
 `#wpwrap` and not on the body.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42205#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform