[wp-trac] [WordPress Trac] #42180: Escape key does not work on Attachment Detail popup when navigating fast

[WordPress Trac]

#42180: Escape key does not work on Attachment Detail popup when navigating fast
------------------------------+-----------------------------------------
 Reporter:  subrataemfluence  |       Owner:  adamsilverstein
     Type:  defect (bug)      |      Status:  assigned
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Media             |     Version:  4.8.2
 Severity:  normal            |  Resolution:
 Keywords:                    |     Focuses:  javascript, administration
------------------------------+-----------------------------------------

Comment (by adamsilverstein):

 In [attachment:42180.diff] :

 When hitting the ends of navigating (the first or last item), instead of
 blurring the next/back button, focus on the modal element. blurring was
 removing focus entirely, and keydown events were no longer firing on the
 modal.

 ps. I was able to reproduce very easily without going fast at all, simply:
 * open modal from the second image,
 * hit back (left arrow key) to go to the first image,
 * hit back again to trigger the error,
 * hit escape - before the patch it fails, after the patch it works.

 @subrataemfluence can you verify this fixes the issue?

 @afercia can you validate the focus placement on $el makes sense? i was
 able to tab back into the controls very easily, however it is possible we
 shouldn't be doing anything with focus here and I appreciate your
 feedback.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42180#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform