[wp-trac] [WordPress Trac] #41722: wpdb::db_connect() does not connect to IPv6 address of mysql server

[WordPress Trac]

#41722: wpdb::db_connect() does not connect to IPv6 address of mysql server
-------------------------------------------------+-------------------------
 Reporter:  fierevere                            |       Owner:  pento
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  4.9
Component:  Database                             |     Version:  4.8.1
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-unit-    |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by birgire):

 Thanks for the heads up @markjaquith

 In [attachment:41722.5.diff]

 - Replace {{{assertEquals()}}} with {{{assertSame()}}}
 - Added the same empty check for {{{$socket}}}, as done in
 [attachment:41722-sockets-fix.diff] for the {{{$port}}}.

 Can we do the same for {{{$host}}}? In the first test, within
 {{{parse_db_host_data_provider()}}}, the empty string {{{DB_HOST}}} is
 expected to be parsed into a {{{null}}} {{{$host}}}. So this patch assumes
 that output for empty {{{$host}}}. It would be good to have others
 verifying that this is valid.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41722#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform