[wp-trac] [WordPress Trac] #39686: Upgrade MediaElement to 4.X

[WordPress Trac]

#39686: Upgrade MediaElement to 4.X
--------------------------------+----------------------------------------
 Reporter:  rafa8626            |       Owner:
     Type:  enhancement         |      Status:  reopened
 Priority:  high                |   Milestone:  4.9
Component:  External Libraries  |     Version:  4.7.1
 Severity:  normal              |  Resolution:
 Keywords:  needs-patch         |     Focuses:  accessibility, javascript
--------------------------------+----------------------------------------
Changes (by johnbillion):

 * keywords:  has-patch commit => needs-patch
 * priority:  normal => high
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 This change is causing JavaScript errors on the post editing screen.

 {{{
 Uncaught TypeError: Language code must have format `xx` or `xx-xx`
     at Object.s.language (mediaelement-and-
 player.min.js?ver=4.2.5-74e01a40:12)
     at Object.o.5.15 (mediaelement-and-
 player.min.js?ver=4.2.5-74e01a40:12)
     at i (mediaelement-and-player.min.js?ver=4.2.5-74e01a40:12)
     at e (mediaelement-and-player.min.js?ver=4.2.5-74e01a40:12)
     at mediaelement-and-player.min.js?ver=4.2.5-74e01a40:12
 s.language @ mediaelement-and-player.min.js?ver=4.2.5-74e01a40:12
 o.5.15 @ mediaelement-and-player.min.js?ver=4.2.5-74e01a40:12
 i @ mediaelement-and-player.min.js?ver=4.2.5-74e01a40:12
 e @ mediaelement-and-player.min.js?ver=4.2.5-74e01a40:12
 (anonymous) @ mediaelement-and-player.min.js?ver=4.2.5-74e01a40:12
 wp-mediaelement.js?ver=4.9-alpha-40870-src:51
 }}}
 {{{
 Uncaught TypeError: $(...).not(...).filter(...).mediaelementplayer is not
 a function
     at HTMLDocument.initialize (wp-
 mediaelement.js?ver=4.9-alpha-40870-src:51)
     at i (jquery.js?ver=1.12.4:2)
     at Object.fireWith [as resolveWith] (jquery.js?ver=1.12.4:2)
     at Function.ready (jquery.js?ver=1.12.4:2)
     at HTMLDocument.K (jquery.js?ver=1.12.4:2)
 initialize @ wp-mediaelement.js?ver=4.9-alpha-40870-src:51
 i @ jquery.js?ver=1.12.4:2
 fireWith @ jquery.js?ver=1.12.4:2
 ready @ jquery.js?ver=1.12.4:2
 K @ jquery.js?ver=1.12.4:2
 wp-auth-check.js?ver=4.9-alpha-40870-src:101
 }}}
 {{{
 Uncaught TypeError: Cannot read property 'hasClass' of undefined
     at HTMLDocument.<anonymous> (wp-auth-
 check.js?ver=4.9-alpha-40870-src:101)
     at HTMLDocument.dispatch (jquery.js?ver=1.12.4:3)
     at HTMLDocument.r.handle (jquery.js?ver=1.12.4:3)
     at Object.trigger (jquery.js?ver=1.12.4:3)
     at Object.jQuery.event.trigger (jquery-migrate.js?ver=1.4.1:633)
     at HTMLDocument.<anonymous> (jquery.js?ver=1.12.4:3)
     at Function.each (jquery.js?ver=1.12.4:2)
     at jQuery.fn.init.each (jquery.js?ver=1.12.4:2)
     at jQuery.fn.init.trigger (jquery.js?ver=1.12.4:3)
     at Object.<anonymous> (heartbeat.js?ver=4.9-alpha-40870-src:400)
 }}}
 Seen in Chrome 61 on macOS. Git bisected back to this commit.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39686#comment:109>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform