[wp-trac] [WordPress Trac] #42574: MediaElement upgrade causing JS errors when certain languages are in use e.g de_DE-formal

[WordPress Trac]

#42574: MediaElement upgrade causing JS errors when certain languages are in use
e.g de_DE-formal
-------------------------------------+-------------------------------------
 Reporter:  erich_k4wp               |       Owner:
     Type:  defect (bug)             |      Status:  reopened
 Priority:  high                     |   Milestone:  4.9.1
Component:  Media                    |     Version:  4.9
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch 2nd-opinion    |     Focuses:  javascript,
  needs-testing                      |  administration
-------------------------------------+-------------------------------------

Comment (by SergeyBiryukov):

 As noted in comment:41, the language is simply used as an ID, and we're
 only passing a single set of strings, so no need to complicate things :)

 [attachment:42574.5.diff] is my take based on the approach in
 [attachment:42574.2.diff]. A new function should not be necessary,
 reducing the language tag to the first subtag with `strtok()` should be
 enough for our purposes here.

 [attachment:42574.4.diff] would also work, but seems like an overkill.

 [attachment:42574.3.diff] seems a bit too technical for translators.
 Without looking deep into MediaElement.js code, how are they supposed to
 know which language tags are supported and which are not? Unlike in
 [36802], there's no documentation link here.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42574#comment:45>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform