[wp-trac] [WordPress Trac] #6531: Recursively search for files in theme and plugin editors

WordPress Trac noreply at wordpress.org
Mon Nov 27 02:58:04 UTC 2017


#6531: Recursively search for files in theme and plugin editors
-------------------------------------------------+-------------------------
 Reporter:  torbens                              |       Owner:  pento
     Type:  defect (bug)                         |      Status:  closed
 Priority:  high                                 |   Milestone:  4.9
Component:  Themes                               |     Version:  2.5
 Severity:  minor                                |  Resolution:  fixed
 Keywords:  theme-editor has-patch has-unit-     |     Focuses:
  tests                                          |  administration
-------------------------------------------------+-------------------------

Comment (by dd32):

 In [changeset:"42242"]:
 {{{
 #!CommitTicketReference repository="" revision="42242"
 Theme/Plugin Editor: Remove the caching added in [41806] as it causes more
 problems than it fixes.

 While caching here seemed like a good idea in theory, in practice the
 cache would be often stale causing development issues.
 We exclude common folders (such as `node_modules`) from the scanning to
 avoid directories which are not useful to the end-user, so as long as
 those exclusion lists are held up this shouldn't cause too much of a
 degredation in the future.
 We may consider adding caching here again in the future if it's determined
 that it is really needed.

 Props precies, ibenic, mariovalney, schlessera, and all the others who
 commented on the ticket(s).
 This partually reverts [41806].
 See #6531.
 Fixes #42573.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/6531#comment:72>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list