[wp-trac] [WordPress Trac] #41057: Update PHP codebase per WordPress PHP Coding Standards

WordPress Trac noreply at wordpress.org
Fri Nov 24 00:04:50 UTC 2017


#41057: Update PHP codebase per WordPress PHP Coding Standards
----------------------------+-----------------------
 Reporter:  netweb          |       Owner:  pento
     Type:  task (blessed)  |      Status:  accepted
 Priority:  normal          |   Milestone:  5.0
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  early commit    |     Focuses:
----------------------------+-----------------------

Comment (by jrf):

 @pento Just a couple of notes/suggestions before you commit this:

 1. Previously discussed in various issues in WPCS - it would be highly
 recommended to manually fix the issues the
 `WordPress.WhiteSpace.PrecisionAlignment` sniff throws up '''before'''
 running the big patch for improved results.
 2. There is one [https://github.com/squizlabs/PHP_CodeSniffer/pull/1599
 open PR upstream] in PHPCS which solves one of the open issues as well as
 fixes space indented comments (currently not being fixed).
 A branch including this can be found here:
 https://github.com/jrfnl/PHP_CodeSniffer/tree/WP-Core/test-run - I will
 update that branch with the latest PHPCS master this weekend.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/41057#comment:93>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list