[wp-trac] [WordPress Trac] #37375: Several test setUp() methods don't call parent::setUp()

WordPress Trac noreply at wordpress.org
Thu Nov 23 11:47:40 UTC 2017


#37375: Several test setUp() methods don't call parent::setUp()
------------------------------+--------------------------
 Reporter:  johnbillion       |       Owner:  johnbillion
     Type:  defect (bug)      |      Status:  accepted
 Priority:  normal            |   Milestone:  5.0
Component:  Build/Test Tools  |     Version:
 Severity:  minor             |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+--------------------------

Comment (by birgire):

 [attachment:37375.2.diff] adds the {{{parent::setUp()}}} call in
 - {{{Tests_Taxonomy_GetObjectTaxonomies:setUp()}}},
 - {{{Tests_WP_Embed:setUp()}}}.
 Also includes the {{{Tests_Image_Editor::setUp()}}} instead of
 {{{Tests_Image_Editor::setup()}}}.

 For the two additional {{{parent::setUp()}}}, I tested:

 {{{
 phpunit --group taxonomy
 OK (615 tests, 1424 assertions)

 phpunit --group oembed
 OK (104 tests, 290 assertions)

 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37375#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list