[wp-trac] [WordPress Trac] #12423: Include default code editor

WordPress Trac noreply at wordpress.org
Sun Nov 19 19:22:33 UTC 2017


#12423: Include default code editor
-------------------------------------------+----------------------------
 Reporter:  scribu                         |       Owner:  westonruter
     Type:  feature request                |      Status:  closed
 Priority:  normal                         |   Milestone:  4.9
Component:  Editor                         |     Version:  3.0
 Severity:  normal                         |  Resolution:  fixed
 Keywords:  has-patch commit has-dev-note  |     Focuses:  accessibility
-------------------------------------------+----------------------------

Comment (by GermanKiwi):

 Replying to [comment:140 melchoyce]:
 > > Note: if the Codemirror is going to be implemented in the text editor
 for posts, then it has to be an opt-in, because that is an essential part
 of WP's functionality.
 >
 > We're going to forego this one for now. :)

 Hi @melchoyce - firstly, thanks to you and the other contributors for your
 work with this improvement to WP!

 I have a question: I'm a bit puzzled why the addition of CodeMirror to the
 text editor was dropped in the end, as you wrote above? It had seemed to
 me, from what George and Matt wrote in [comment:124] and [comment:125],
 that they were agreeing with the idea of including it on the text editor,
 albeit with some kind of opt-in or opt-out feature. And [#comment:133
 rianrietveld] echoed the same sentiment.

 I can't see anything in the comments that followed to explain why it was
 decided to keep CodeMirror from the text editor and only add it to the
 theme/plugin editor, HTML widget, and CSS customizer. I wonder if you
 could clarify why that was decided in the end?

 I guess what I don't understand is the difference between adding it to the
 theme/plugin editor but not to the text editor, and why it's okay to add
 it to the former but not the latter. Especially in light of those videos
 at [#comment:82] which showed the problems with CodeMirror in the theme
 editor when using accessibility tools. To me, it would seem logical to be
 either "both" or "neither".

 I'm not looking for an argument about the decision :) - just trying to
 understand the logic behind it! My personal preference was to have
 CodeMirror also added to the text editor too, but opt-in only, so it had
 to be enabled by those who wanted it. That made good sense to me.

 Seeing as you wrote "forgo this one for now", are there specific plans to
 add it to the text editor in the future?

 Thanks again!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/12423#comment:167>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list