[wp-trac] [WordPress Trac] #39221: Customize: Prevent setting previewing logic when settings will be saved

WordPress Trac noreply at wordpress.org
Thu Nov 9 04:44:39 UTC 2017


#39221: Customize: Prevent setting previewing logic when settings will be saved
---------------------------------------------+--------------------------
 Reporter:  westonruter                      |       Owner:  westonruter
     Type:  defect (bug)                     |      Status:  closed
 Priority:  normal                           |   Milestone:  4.9
Component:  Customize                        |     Version:  4.7
 Severity:  normal                           |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests commit  |     Focuses:
---------------------------------------------+--------------------------

Comment (by westonruter):

 In [changeset:"42139"]:
 {{{
 #!CommitTicketReference repository="" revision="42139"
 Customize: Fix reliability of just-in-time publishing for changesets that
 miss their schedule when visiting `customize.php`.

 When just doing `wp_publish_post()` for the changeset from
 `customize.php`, any option-based settings will fail to get saved because
 `WP_Customize_Manager` would have already been loaded with
 `settings_previewed`, resulting in `update_option()` calls being short-
 circuited. So an admin-ajax request to `customize_save` is used to work
 around this.

 Props westonruter, jeremyfelt, dlh for testing, LittleBigThing for
 testing.
 Amends [41626].
 See #28721, #39221.
 Fixes #42457 for 4.9.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/39221#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list