[wp-trac] [WordPress Trac] #42439: Update random_compat external library for PHP 7 linting failure

[WordPress Trac]

#42439: Update random_compat external library for PHP 7 linting failure
--------------------------------+-----------------------------
 Reporter:  jrdelarosa          |      Owner:
     Type:  defect (bug)        |     Status:  new
 Priority:  normal              |  Milestone:  Awaiting Review
Component:  External Libraries  |    Version:  trunk
 Severity:  normal              |   Keywords:
  Focuses:                      |
--------------------------------+-----------------------------
 Currently the random_compat library included with WordPress core is the
 only part that fails against PHP 7 linting. As a tech at WP Engine I've
 noticed that our customers run into problems when pushing to their remote
 repositories, so I did a bit of investigation and it looks like the
 external library included was updated to correct this as of October 2016
 as commented here: https://core.trac.wordpress.org/ticket/35665#comment:6

 I've created the attached diff and it passes all of the unit tests
 included with core. I've also verified that it lints correctly via the
 following command.


 {{{
 for file in $(find . -type f -name "*.php"); do php -l $file; done | grep
 -v "No syntax errors"
 }}}


 #35665 - Previously updated to version 1.2.1 in ticket #35665

--
Ticket URL: <https://core.trac.wordpress.org/ticket/42439>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform