[wp-trac] [WordPress Trac] #37893: Implementation of is_registered_sidebar() doesn't match its documented signature

WordPress Trac noreply at wordpress.org
Tue May 23 11:29:38 UTC 2017


#37893: Implementation of is_registered_sidebar() doesn't match its documented
signature
--------------------------+------------------------------
 Reporter:  mdgl          |       Owner:  welcher
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Widgets       |     Version:  4.4
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+------------------------------
Changes (by welcher):

 * keywords:  needs-patch close => needs-patch


Comment:

 Replying to [comment:20 mdgl]:

 > Updating the documentation blocks might be an appropriate fix, but it
 would need to be clear that the use of an `int` in functions
 `dynamic_sidebar` and `is_active_sidebar` is not the same as the use of
 `int` in all the other widget functions.
 >
 > Still, not much interest in this, so suggest close.

 Instead of closing, why not write up a patch that updates the doc? Well
 documented code goes a very long way and is extremely helpful in
 situations like this where there are inconsistent implementations. I think
 it's worth the effort.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37893#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list